airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

fix: update ingress template value for < 1.19-0

Open wjmolina opened this issue 2 years ago • 5 comments
trafficstars

What

The original service name for semverCompare "<1.19-0", which is

{{ $fullName }}-svc

is not the correct name of the service. Instead, it should be

{{ $.Release.Name }}-airbyte-webapp-svc

This is the current value for semverCompare ">=1.19-0".

Strangely, the if part was updated in a previous PR, but the same change was not made in the else part (see the image below). This PR rectifies this discrepancy.

image

How

The serviceName (for semverCompare "<1.19-0") was changed from {{ $fullName }}-svc to {{ $.Release.Name }}-airbyte-webapp-svc.

Can this PR be safely reverted / rolled back?

  • [X] YES 💚
  • [ ] NO ❌

🚨 User Impact 🚨

There are no breaking changes. The user (of this version) currently cannot access the UI. After this is merged, the user will be able to access the UI again.

wjmolina avatar Sep 20 '23 18:09 wjmolina

@cpdeethree can you chec this contribution?

marcosmarxm avatar Oct 10 '23 22:10 marcosmarxm

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 12 '23 23:12 sonarqubecloud[bot]

@marcosmarxm i think this got lost in the mix, if you want to route it back through the process

c-p-b avatar Jan 06 '24 00:01 c-p-b

@marcosmarxm i think this got lost in the mix, if you want to route it back through the process

Thanks for bumping this!

wjmolina avatar Feb 20 '24 17:02 wjmolina

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 07 '24 21:05 CLAassistant