airbyte-platform
airbyte-platform copied to clipboard
fix: update ingress template value for < 1.19-0
What
The original service name for semverCompare "<1.19-0", which is
{{ $fullName }}-svc
is not the correct name of the service. Instead, it should be
{{ $.Release.Name }}-airbyte-webapp-svc
This is the current value for semverCompare ">=1.19-0".
Strangely, the if part was updated in a previous PR, but the same change was not made in the else part (see the image below). This PR rectifies this discrepancy.
How
The serviceName (for semverCompare "<1.19-0") was changed from {{ $fullName }}-svc to {{ $.Release.Name }}-airbyte-webapp-svc.
Can this PR be safely reverted / rolled back?
- [X] YES 💚
- [ ] NO ❌
🚨 User Impact 🚨
There are no breaking changes. The user (of this version) currently cannot access the UI. After this is merged, the user will be able to access the UI again.
@cpdeethree can you chec this contribution?
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code
@marcosmarxm i think this got lost in the mix, if you want to route it back through the process
@marcosmarxm i think this got lost in the mix, if you want to route it back through the process
Thanks for bumping this!