airbyte-platform
airbyte-platform copied to clipboard
fix(helm): airbyte aws_access/secret_key bad conditions for templating in server
What
The worker container and server container deployment definitions are not the same and handle aws_access_key and secret_key differently. The server templating in the deployment takes a shortcut checking only for access key secret and secret key existingSecretKey parameter in helm.
How
Describe the solution this PR sync both behavior (worker/server deployment template) and fixes a condition where the access key can be hard coded and the secret key based on a secret and both settings are ignored by the condition as it was.
Can this PR be safely reverted / rolled back?
If unsure, leave it blank.
- [X] YES 💚
- [ ] NO ❌
🚨 User Impact 🚨
Are there any breaking changes? -> No it should work better than before
What is the end result perceived by the user? -> A working deployment
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
ogirardot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.