multidict icon indicating copy to clipboard operation
multidict copied to clipboard

🧪 Skip tests when building `x86_64` wheels

Open Jamim opened this issue 1 year ago • 2 comments
trafficstars

Hello @webknjaz,

What do these changes do?

Testing is redundant when building wheels for x86_64 since there are dedicated jobs that run tests for this arch. Disabling it reduces build time noticeably.

Related documentation:

  • https://cibuildwheel.readthedocs.io/en/stable/options/#test-skip

Are there changes in behavior for the user?

CI/CD build time will be reduced.

Related issue number

N/A

Checklist

  • [x] I think the code is well written
  • [x] Documentation reflects the changes

Best regards!

Jamim avatar Feb 03 '24 05:02 Jamim

Hello @webknjaz, What do you think of the proposed changes?

Jamim avatar Feb 11 '24 19:02 Jamim

I'm hesitant about this: cibuildwheel tests run under a different environment so I feel like we'd benefit from covering more ground this way. Yes, it'd cut the CI use but I'm not sure that's what we need. Besides, if we were to disable this, it should be on the CI configuration level, not a tool-global — local runs would still benefit from producing wheels that go through the testing stage.

webknjaz avatar Feb 16 '24 14:02 webknjaz