multidict icon indicating copy to clipboard operation
multidict copied to clipboard

♻️ Refactor pickle tests

Open Jamim opened this issue 1 year ago • 3 comments
trafficstars

Hello @webknjaz,

What do these changes do?

The main goal of these changes is to make test_pickle.py more readable and eliminate get_pickles.py.

These changes:

  • add dict_data, pickled_data, and pickle_file_path fixtures
  • rename test_pickle to test_unpickle
  • add test_pickle_format_stability
  • replace test_load_from_file with test_pickle_backward_compatibility
  • replace get_pickles.py with test_write_pickle_file

Are there changes in behavior for the user?

No.

Related issue number

  • #922

This PR is alternative to:

  • #924

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes

Best regards!

Jamim avatar Feb 01 '24 02:02 Jamim

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.63%. Comparing base (f705368) to head (f4b7524).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   95.09%   95.63%   +0.53%     
==========================================
  Files          21       20       -1     
  Lines        2407     2404       -3     
  Branches      275      271       -4     
==========================================
+ Hits         2289     2299      +10     
+ Misses         46       33      -13     
  Partials       72       72              
Flag Coverage Δ
CI-GHA 95.63% <100.00%> (+0.53%) :arrow_up:
MyPy 67.35% <41.46%> (+0.29%) :arrow_up:
unit 99.51% <100.00%> (+0.58%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '24 03:02 codecov[bot]

Hello @webknjaz,

Would you mind reviewing this PR once you have a spare time?

Thanks in advance!

Jamim avatar Mar 19 '24 21:03 Jamim