aiokafka icon indicating copy to clipboard operation
aiokafka copied to clipboard

refactor: add type hints to protocol

Open odysa opened this issue 1 year ago • 1 comments

Changes

Add type hints to the protocol module

Checklist

  • [x] I think the code is well written
  • [ ] Unit tests for the changes exist
  • [ ] Documentation reflects the changes
  • [ ] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

odysa avatar Apr 09 '24 01:04 odysa

This PR seem to have been superseded, should it be closed?

antonagestam avatar Jul 02 '24 19:07 antonagestam

Already implemented in #999 and #1005

ods avatar Jul 06 '24 14:07 ods