aiokafka icon indicating copy to clipboard operation
aiokafka copied to clipboard

add more type hints

Open alm0ra opened this issue 1 year ago • 2 comments

Changes

add more typo for integrate with mypy Fixes #980

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes
  • [x] Add a new news fragment into the CHANGES folder

alm0ra avatar Feb 17 '24 19:02 alm0ra

@ods

I wanted to give you a quick update on the type hint fixes I've been working on. I've made some significant progress and wanted to share it with you. After carefully reviewing and addressing the type hint issues, I've managed to fix about 50% of them across the files. I made sure to double-check everything with mypy to ensure accuracy.

alm0ra avatar Feb 17 '24 20:02 alm0ra

Codecov Report

Attention: Patch coverage is 99.12664% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.09%. Comparing base (bb15ecf) to head (b34f9bb). Report is 2 commits behind head on master.

:exclamation: Current head b34f9bb differs from pull request most recent head d51ef45. Consider uploading reports for the commit d51ef45 to get more accurate results

Files Patch % Lines
aiokafka/admin/config_resource.py 50.00% 0 Missing and 1 partial :warning:
aiokafka/consumer/subscription_state.py 99.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   95.11%   95.09%   -0.02%     
==========================================
  Files         107      107              
  Lines       16413    16428      +15     
  Branches     2625     2626       +1     
==========================================
+ Hits        15612    15623      +11     
- Misses        522      523       +1     
- Partials      279      282       +3     
Flag Coverage Δ
cext 91.80% <99.12%> (-0.03%) :arrow_down:
integration 94.75% <99.12%> (-0.01%) :arrow_down:
purepy 94.49% <99.12%> (-0.10%) :arrow_down:
unit 42.08% <79.29%> (-2.84%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 17 '24 20:02 codecov[bot]