aiokafka
aiokafka copied to clipboard
Try to reproduce error 41
Changes
The goal of this branch is to reproduce an error of not sending the create/delete topics command to the controller, and getting an error code 41, to then fix it in the admin client, as proposed in https://github.com/aio-libs/aiokafka/pull/865
Checklist
- [ ] I think the code is well written
- [ ] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] Add a new news fragment into the
CHANGESfolder- name it
<issue_id>.<type>(e.g.588.bugfix) - if you don't have an
issue_idchange it to the pr id after creating the PR - ensure type is one of the following:
.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example:
Fix issue with non-ascii contents in doctest text files.
- name it
Codecov Report
Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
Project coverage is 94.95%. Comparing base (
e8383ea) to head (cc60fbe). Report is 27 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| tests/manual/topic_management.py | 0.00% | 18 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 95.04% 94.95% -0.09%
==========================================
Files 107 108 +1
Lines 16408 16426 +18
Branches 2624 2626 +2
==========================================
+ Hits 15595 15598 +3
- Misses 536 552 +16
+ Partials 277 276 -1
| Flag | Coverage Δ | |
|---|---|---|
| cext | 91.67% <0.00%> (-0.09%) |
:arrow_down: |
| integration | 94.60% <0.00%> (-0.09%) |
:arrow_down: |
| purepy | 94.39% <0.00%> (-0.12%) |
:arrow_down: |
| unit | 44.85% <0.00%> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.