aiokafka icon indicating copy to clipboard operation
aiokafka copied to clipboard

Why ConsumerRebalanceListener is not expose when create a Consumer?

Open marcosschroh opened this issue 3 years ago • 0 comments
trafficstars

Hi,

Thanks for the work that you are doing!!

According to the code, the only way to use the ConsumerRebalanceListener is using the subscribe method, I was wondering: Why is not also possible to set a ConsumerRebalanceListener when a Consumer is created using the __init__? I think if we do this, the testing will become easier because of mocking and you won’t be force to use the subscribe method.

In the init method is used self._subscription.subscribe(…) which accepts a ConsumerRebalanceListener argument, so I think it is possible to make it.

Ideally, I think both options should be possible. If the user set a new ConsumerRebalanceListenter using the subscribe method, it should prevail.

what do you think?

marcosschroh avatar Jul 01 '22 10:07 marcosschroh