aiokafka icon indicating copy to clipboard operation
aiokafka copied to clipboard

add test for sasl ssl

Open LizardWizzard opened this issue 5 years ago • 2 comments

Changes

Hello! Thank you for great library! Just wanted to test if sasl_ssl auth method is working correctly while setting it up for my project. Realised that this scenario is missing in library's functional tests. So I've added it.

By the way, when tried to run tests on master there was a bunch of warnings like RuntimeWarning: coroutine 'TestKafkaClientIntegration.test_failed_bootstrap' was never awaited so many tests didnt actually run. When tried on top of the latest release tests run smoothly

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes
  • [ ] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .misc: A ticket has been closed, but it is not of interest to users.

LizardWizzard avatar Oct 06 '20 08:10 LizardWizzard

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '20 10:11 CLAassistant

Thanks for the contribution! I remember having issues with the SSL+SASL scenario, because we create certificates for SSL in a very simple manner, not sure what was the specific problem.

tvoinarovskyi avatar Jan 03 '22 11:01 tvoinarovskyi