aiidateam
`Tests` : `test_all_plugins.py` is poor
Improve test_all_plugins some tests are missing for instance chown.
Other tests, don't really challenge the the interface behavior critically..
Improve
test_all_pluginssome tests are missing for instancechown.Other tests, don't really challenge the the interface behavior critically..
hey @khsrali should i add a function chown in test_all_plugins.py like test_chown
Hi @FARDEEN-785, If that helps you to grasp more understanding of the code base for future contributions, then sure, by all means go ahead!
Hi @Muhammad-Rebaal
Check this file: test_all_plugins.py some tests although being in place, they don't really cover the pitfalls.
You can think through and imagine all scenarios for each function, and discover cases that's not already being covered in the tests.
Check this file:
test_all_plugins.pysome tests although being in place, they don't really cover the pitfalls. You can think through and imagine all scenarios for each function, and discover cases that's not already being covered in the tests.
Yeah sure! I'll take a look at this test_all_plugins.py file and re-imagine some good test cases that would work better for the project.
@Muhammad-Rebaal doing that, you can skip any test directly related to get, put, and copy methods. I already have fix patches for them, which I plan to commit in the right time in future.
Hi @FARDEEN-785, If that helps you to grasp more understanding of the code base for future contributions, then sure, by all means go ahead!
oky i will try to add a small functions to see if works
Hi @FARDEEN-785, If that helps you to grasp more understanding of the code base for future contributions, then sure, by all means go ahead!
oky i will try to add a small functions to see if works
@FARDEEN-785 Added a small function chown in ['test_all_plugins.py'] #6788
The description is a bit vague, (which is good as a "good first issue" 😄 ) so it leaves to developers to think about what need to improve, for who want to improve the test cases, when open the PR, please first describe the improvement you want to bring in in you PR.