jessica icon indicating copy to clipboard operation
jessica copied to clipboard

WIP whitespace and indentation

Open erights opened this issue 6 years ago • 3 comments
trafficstars

DO NOT MERGE: Based on an ancient master

An experiment in whitespace layout for grammar definition. Only approve if you like it better,

erights avatar Nov 18 '19 02:11 erights

Assumes reading at 100 columns.

On Sun, Nov 17, 2019, 6:17 PM Mark S. Miller [email protected] wrote:

An experiment in whitespace layout for grammar definition. Only approve if you like it better,

You can view, comment on, or merge this pull request online at:

https://github.com/agoric-labs/jessica/pull/21 Commit Summary

  • whitespace

File Changes

Patch Links:

  • https://github.com/agoric-labs/jessica/pull/21.patch
  • https://github.com/agoric-labs/jessica/pull/21.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/agoric-labs/jessica/pull/21?email_source=notifications&email_token=AACC3TH3WVQRMCPHD5DHTK3QUH3KJA5CNFSM4JONEBNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZ5B2EQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACC3TCWOJAKTUT4MKDFVN3QUH3KJANCNFSM4JONEBNA .

erights avatar Nov 18 '19 02:11 erights

Thanks, I do like the sentiment of the change.

Unfortunately, the lib/*.js files are generated by ./build.bat from the lib/*.js.ts files, and because of the type annotations in the *.js.ts files, your changes don't apply cleanly to them.

Let's revisit this when we have time to format the grammars in the *.js.ts files better.

michaelfig avatar Nov 19 '19 15:11 michaelfig

Let's revisit this when we have time to format the grammars in the *.js.ts files better.

Converted to Draft

erights avatar Sep 18 '21 02:09 erights