vendor: update gitea sdk v0.12.0 -> 0.14.0

[6543]

and adopt changes

[6543]

I think main issue is fixed with v0.13.1 ...

-> https://gitea.com/gitea/go-sdk/pulls/429

[6543]

@sgotti the gitea version agola test against is too old, it just turns out the new version do not run properly?

Can you give me a hint where the gitea test instance is setup for the test?

[6543]

@sgotti this pull is finally ready :rocket:

[sgotti]

@6543 Thanks for the PR.

I noticed that now the call to gitea NewClient can return an error since it calls the server to check the minimal version. This is quite different from other client implementations where they just create a client without doing any call so you can cache and use the client when needed. In such case if in the moment of the call to NewClient the server is temporarily unreachable the call will fail).

Anyway, does this mean that the minimal required gitea version is 1.11?

[6543]

@sgotti yes gitea >= 1.11 requirement

[6543]

@sgotti what's up? do you need more information?

[sgotti]

@6543 No, just not enough time. My only worries were related to the client checking the Gitea version and I wanted to check if Gitea 1.11 is really needed. The current client as far as I know works with all the versions of Gitea, so also the new one should work also with version before 1.11.

[6543]

by version checking we avoid unwanted & unpredictable behaviour - since api got a lot of changes since then. beside that and the fact that v1.12 start pagination support, you really should not run gitea below v1.13.7 for security reasons ...

@sgotti so in my opinion if one run a gitea older than v1.11 he either also will likely stick with an older agola version or do custom patches anyway ...

so I'm not sure why agola should run with all gitea versions, witch it in fact never did since early versions do miss a lot of api features you use ...

---

PS: yes take your time to test this patch

[6543]

@sgotti resolved conflict and adjust to current codebase

[sgotti]

Already updated in #385