openfpga-SNES icon indicating copy to clipboard operation
openfpga-SNES copied to clipboard

PAL doesn't support multiple image heights

Open Urbalcloud opened this issue 3 years ago • 12 comments

noticing some glitching at the bottom of the screen on a few games in the snes core, including Super Adventure Island and Zelda: LttP. Attempting to attach pics showing the issues

BFFB276B-CBE6-406E-8093-5135F1964A9B 13258000-F976-4B57-87B4-28482DFDCC05

Urbalcloud avatar Sep 29 '22 17:09 Urbalcloud

I noticed the same issue in Nightmare Busters (Unlicensed).

italiangrandma avatar Sep 29 '22 17:09 italiangrandma

Tried the same games, no issues here. Their ROMs are either headered, or not Checksum/ROM size fixed. Edit: or it's PAL.

ifighftdragons avatar Sep 29 '22 18:09 ifighftdragons

Are these PAL games or did you edit video.json? Looks like it's using the wrong video.json settings, which is most likely to occur with PAL

agg23 avatar Sep 29 '22 18:09 agg23

Are these PAL games or did you edit video.json? Looks like it's using the wrong video.json settings, which is most likely to occur with PAL

I did just notice that Nightmare Busters is a PAL game after running it through the Advanced SNES Rom Utility. I also fixed the checksum and rom size. Nightmare Busters still shows the red line at the bottom, so it must be related to the game being PAL.

@ifighftdragons Did you test Nightmare Busters?

Edit: Just tested a handful of PAL games and can confirm the red line at the bottom appears in all of them.

italiangrandma avatar Sep 29 '22 18:09 italiangrandma

@italiangrandma: I just tested the games pictured. PAL games are already mentioned by agg23 to not be working properly due to waiting on updates from Analogue, so it shouldn't be logged as an issue here.

ifighftdragons avatar Sep 29 '22 18:09 ifighftdragons

@italiangrandma: I just tested the games pictured. PAL games are already mentioned by agg23 to not be working properly due to waiting on updates from Analogye, so it shouldn't be logged as an issue here.

Ah yeah, gotcha. For some reason I thought that had been fixed in this release. I wasn't intending to "log it as an issue", but just adding context to this issue logged by Urbalcloud (which, I guess shouldn't have been logged in the first place :P).

italiangrandma avatar Sep 29 '22 18:09 italiangrandma

Edit: Just tested a handful of PAL games and can confirm the red line at the bottom appears in all of them.

I must have messed something up. This shouldn't be happening. If you open the core statistics, what number appears after "Sync OK"?

agg23 avatar Sep 29 '22 18:09 agg23

Looks like it was a PAL rom. Converted to NTSC and it worked fine.

Urbalcloud avatar Sep 29 '22 18:09 Urbalcloud

Edit: Just tested a handful of PAL games and can confirm the red line at the bottom appears in all of them.

I must have messed something up. This shouldn't be happening. If you open the core statistics, what number appears after "Sync OK"?

~~Hmmm, I'm not sure how to look at that...is it a button combo or something? I don't see any option for Statistics in the menus or anything to enable in the json files.~~

Ok, I found the setting. The number that appears after Sync OK for all PAL roms I'm loading is 2.

Edit: Ok, this is odd....after turning on the Statistics setting, I loaded up a US rom for comparison (to see the sync value; it just says "Sync OK" with no number after it). Went back and loaded up a PAL rom again and suddenly the red bar is gone for every PAL game I load thereafter. Now there is just black space, which I believe is intended behavior? Turning the console back off then on again, this trick doesn't work anymore.

italiangrandma avatar Sep 29 '22 19:09 italiangrandma

It's a bug that anything shows down there, it's just black sometimes if the cores previously loaded black there.

agg23 avatar Sep 29 '22 20:09 agg23

It looks like it's complaining because I didn't update the aspect ratio to account for the changed values. Can you try this:

{
  "video": {
    "magic": "APF_VER_1",
    "scaler_modes": [
      {
        "width": 512,
        "height": 224,
        "aspect_w": 8,
        "aspect_h": 7,
        "rotation": 0,
        "mirror": 0
      },
      {
        "width": 512,
        "height": 224,
        "aspect_w": 4,
        "aspect_h": 3,
        "rotation": 0,
        "mirror": 0
      },
      {
        "width": 512,
        "height": 240,
        "aspect_w": 16,
        "aspect_h": 15,
        "rotation": 0,
        "mirror": 0
      },
      {
        "width": 512,
        "height": 240,
        "aspect_w": 4,
        "aspect_h": 3,
        "rotation": 0,
        "mirror": 0
      }
    ]
  }
}

These aren't the best possible aspect ratio values; I just want to see if it fixes it. I think 4:3 is probably still broken, but the 16:15 should be right...

agg23 avatar Sep 29 '22 20:09 agg23

Ok, thanks to @italiangrandma, I figured it out. PAL games can either be 240 or 224px tall, and I only tested 240 tall games, hence the sudden issues.

This will be resolved in the next update

agg23 avatar Sep 29 '22 20:09 agg23

Fixed in 0.4.0. Closing

agg23 avatar Nov 10 '22 18:11 agg23