Artur Gainullin
Artur Gainullin
[SYCL/Plugin/level_zero_events_caching.cpp](https://github.com/intel/llvm-test-suite/pull/1138/files#diff-d6364c1be6f81d8a01e5f5ce641014045a2e43fd5f4f0aeb05c251c3de560666) failure is unrelated to this PR, fix is uploaded for review here: https://github.com/intel/llvm-test-suite/pull/1138 HIP backend failures are unrelated because changes are isolated to L0 plugin.
@smaslov-intel Could you please review this PR?
ESIMD/regression/complex-lib-lin.cpp failure unrelated and was seen on another PRs, e.g. https://github.com/intel/llvm/pull/12367
``` Failed Tests (8): SYCL :: Assert/assert_in_kernels_win.cpp SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp SYCL :: Assert/assert_in_multiple_tus_win.cpp SYCL :: Assert/assert_in_one_kernel_win.cpp SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp SYCL :: Plugin/sycl-ls-unified-runtime.cpp ``` These...
> LGTM. I could imagine scenarios where the object is built with `-fpreview-breaking-changes` but the option is not used during the link (or vice-versa) causing different sycl libs to be...
Fixed in https://github.com/intel/llvm/pull/12951
I'm sorry for the delayed review.
> @intel/llvm-gatekeepers This is ready for merge. Merge button is blocked because of requested changes, explicit approval from @AlexeySachkov is needed.
@LU-JOHN Introduced test fails in pre-commit: ``` 2024-05-10T17:40:26.8989941Z env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/LLVMIntrinsicLowering/Output/bitreverse.cpp.tmp.out 2024-05-10T17:40:26.8990827Z # executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/LLVMIntrinsicLowering/Output/bitreverse.cpp.tmp.out 2024-05-10T17:40:26.8991396Z # .---command stderr------------ 2024-05-10T17:40:26.8991920Z # | terminate called after throwing an...
Fixed in https://github.com/intel/llvm/pull/14204