envalid icon indicating copy to clipboard operation
envalid copied to clipboard

docs: Add logo

Open simenandre opened this issue 4 years ago • 4 comments

Hello 👋

Thank you again for this awesome package. I had some fun playing around with a logo for envalid, so I thought I'd listen in on what you/people think about it. Maybe it could be used for envalid?

Couldn't make up my mind if it should be centred or aligned left, so I'm opening up two pull requests. This one has the header centred, but #163 has it aligned left.

See the preview here: https://github.com/cobraz/envalid/tree/add-center-header

simenandre avatar Aug 07 '21 16:08 simenandre

This is nice, thanks! I really like the centered layout, it never occurred me to apply any design sense to the readme :D

Could you just reduce the vertical height (padding) around the logo? It takes up a little too much space for my taste currently. Otherwise LGTM

af avatar Aug 08 '21 04:08 af

Centered layout looks best to me too. Have you thought about how it will look on dark mode? Maybe you could test out a bright color on the bakcground or on the outline of the text?

AnneMatilde avatar Aug 08 '21 08:08 AnneMatilde

Could you just reduce the vertical height (padding) around the logo? It takes up a little too much space for my taste currently. Otherwise LGTM

I looks kind of weird if we just squeeze the box:

Skjermbilde 2021-08-08 kl  12 26 43

So maybe change the form of it to a square box (with some rounded corners)?

Skjermbilde 2021-08-08 kl  12 26 06

Or maybe better, remove the box altogether? What do you think, @AnneMatilde ?

Skjermbilde 2021-08-08 kl  12 24 34

simenandre avatar Aug 08 '21 10:08 simenandre

Sorry for the late response here! I think it looks a million times better without the box. Really cool!

AnneMatilde avatar Oct 11 '21 18:10 AnneMatilde

@af should we land this? :)

simenandre avatar Oct 09 '22 12:10 simenandre

Updated with the third suggestion, see the preview here: https://github.com/cobraz/envalid/tree/add-center-header

simenandre avatar Oct 09 '22 13:10 simenandre

Merged, thanks for revisiting this 👍

af avatar Oct 09 '22 13:10 af