aerospike-client-python icon indicating copy to clipboard operation
aerospike-client-python copied to clipboard

[CLIENT-3146] Add support for free threading mode in Python 3.13

Open juliannguyen4 opened this issue 1 year ago • 1 comments

todo:

  • replace borrowed ref api calls
  • global state
  • Certain C client variables need to be read using atomic functions

notes

  • All header files checked for global objs. only src/include/types.h has global objs
  • All source files checked. The ones with global objs that have been addressed are:
  • [x] geospatial/type.c
  • [x] aerospike.c. TODO: m_size
  • [ ] exception.c
  • [ ] log.c
  • [ ] serializer.c

Not replacing PyDict_GetItem() because it will be removed in another PR

todo extra changes:

  • remove unused exception_types.h

juliannguyen4 avatar Oct 21 '24 19:10 juliannguyen4

Codecov Report

Attention: Patch coverage is 0% with 131 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ce5e01a) to head (e2aa216). Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 0.00% 53 Missing :warning:
src/main/client/batch_operate.c 0.00% 14 Missing :warning:
src/main/client/operate.c 0.00% 13 Missing :warning:
src/main/client/batch_read.c 0.00% 12 Missing :warning:
src/main/convert_expressions.c 0.00% 10 Missing :warning:
src/main/client/batch_apply.c 0.00% 6 Missing :warning:
src/main/exception.c 0.00% 5 Missing :warning:
src/main/geospatial/type.c 0.00% 4 Missing :warning:
src/main/client/batch_write.c 0.00% 3 Missing :warning:
src/main/client/type.c 0.00% 3 Missing :warning:
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #686       +/-   ##
==========================================
- Coverage   81.78%   0.00%   -81.79%     
==========================================
  Files          99      53       -46     
  Lines       14552    9969     -4583     
==========================================
- Hits        11901       0    -11901     
- Misses       2651    9969     +7318     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 21 '24 19:10 codecov-commenter