aerospike-client-python icon indicating copy to clipboard operation
aerospike-client-python copied to clipboard

CLIENT-2476 - Disallow use of add-ops in foreground scans/queries

Open DomPeliniAerospike opened this issue 1 year ago • 3 comments

CLIENT-2476 Disallowed use of operations with foreground queries (foreach and results) Added sufficent testing for each error condition

DomPeliniAerospike avatar Jan 08 '24 16:01 DomPeliniAerospike

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (26f4ea8) 81.25% compared to head (a4ea3c0) 81.29%. Report is 1 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #552      +/-   ##
==========================================
+ Coverage   81.25%   81.29%   +0.04%     
==========================================
  Files          99       99              
  Lines       14897    14913      +16     
==========================================
+ Hits        12105    12124      +19     
+ Misses       2792     2789       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 08 '24 17:01 codecov-commenter

You should also specify in the documentation for query.add_ops() that it should not be used for foreground queries (i.e when calling query.results() or query.foreach()). Also do the same for scans.

juliannguyen4 avatar Jan 10 '24 18:01 juliannguyen4

You should also specify in the documentation for query.add_ops() that it should not be used for foreground queries (i.e when calling query.results() or query.foreach()). Also do the same for scans.

I will add documentation to explain this and let you know when it has been finished.

DomPeliniAerospike avatar Jan 10 '24 19:01 DomPeliniAerospike