graphql-link icon indicating copy to clipboard operation
graphql-link copied to clipboard

Published 20 hours ago • verified publisher icon aerogear

feat: add ability to configure cors in the config

Open namit-chandwani opened this issue 4 years ago • 3 comments

Fixes #58 Through this PR, I have tried to add the functionality that enables CORS to be configured through the graphql-link.yaml file.

Todo (as suggested in https://github.com/aerogear/graphql-link/pull/59#issuecomment-812555175):

  • [ ] runable functionality
  • [ ] docs
  • [ ] including cors in config generation (init CMD)
  • [x] default values

namit-chandwani avatar Apr 02 '21 01:04 namit-chandwani

Is this WIP? Looks like some untested experiment. Please add verification procedure next time so it is clear how you have tested it.

We are missing couple things like:

  • [ ] runable functionality
  • [ ] docs
  • [ ] including cors in config generation (init CMD)
  • [ ] default values

wtrocki avatar Apr 02 '21 14:04 wtrocki

Is this WIP? Looks like some untested experiment.

@wtrocki Yes, this is WIP (sorry for not mentioning this in the PR description). I had planned to make some changes today before asking for a review.

Please read this comment of mine: https://github.com/aerogear/graphql-link/pull/59#discussion_r606310643

Please give me some time, I'll make all the changes that I had planned and also look into the review comments that you have added. Thanks!

namit-chandwani avatar Apr 02 '21 16:04 namit-chandwani

No rush. Sorry for premature review

wtrocki avatar Apr 02 '21 17:04 wtrocki