aeon icon indicating copy to clipboard operation
aeon copied to clipboard

[ENH,MNT] Adding Init saving for deep clustering module

Open hadifawaz1999 opened this issue 1 year ago • 8 comments

Describe the feature or idea you want to propose

Following the updates in #1826 , would be nice to have the same functionality and testing in the deep clustering module.

Describe your proposed solution

  • Adding save_init_model flag parameter to each deep clustering module, default to False
  • Adding init_file_name default to "init_model"
  • Follow same procedure to save init model such as in #1826
  • Adding a save/load testing function in deep clustering module such as in #1826

Describe alternatives you've considered, if relevant

No response

Additional context

No response

hadifawaz1999 avatar Aug 04 '24 11:08 hadifawaz1999

Hi! I'd like to work on this.

ghost avatar Aug 14 '24 13:08 ghost

Aeon-Assign bot assign @neuron283

ghost avatar Aug 14 '24 13:08 ghost

@hadifawaz1999 Where should I add the testing function for deep clustering? Under tests subdirectory there are 2 files: test_deep_clusterer_base.py and test_random_state_deep_learning_cluster.py

ghost avatar Aug 14 '24 16:08 ghost

Also, the tests for classification and regression mentioned in #1826 are missing from latest version of aeon. It's a little confusing. Can you please elaborate?

ghost avatar Aug 14 '24 16:08 ghost

the tests were moved into a new directory recently, @MatthewMiddlehurst could you give us an idea to where the new tests should go after the revamp we got in ?

hadifawaz1999 avatar Aug 14 '24 17:08 hadifawaz1999

If you want the test to run for each individual estimator, see the relevant yield file in testing/estimator_checking/. You will want to add a check there (or look at the functions there currently if just viewing).

Currently, clustering is being ported here #1877.

MatthewMiddlehurst avatar Aug 15 '24 13:08 MatthewMiddlehurst

should I wait before clustering gets ported or just carry on and create a PR?

ghost avatar Aug 15 '24 15:08 ghost

should I wait before clustering gets ported or just carry on and create a PR?

probably will be simpler i think yes

hadifawaz1999 avatar Aug 22 '24 12:08 hadifawaz1999

closing as completed in #2359

hadifawaz1999 avatar Nov 16 '24 13:11 hadifawaz1999