[kubernetes] Fix Ingress-NGINX depends on Cert-Manager
Signed-off-by: Andrei Kvapil [email protected]
Summary by CodeRabbit
-
Bug Fixes
- Improved configuration to automatically disable admission webhooks for cert-manager when the cert-manager addon is not enabled, preventing unnecessary webhook setup.
-
Chores
- Updated Kubernetes chart version to 0.20.1.
- Updated version mapping for the Kubernetes package.
Walkthrough
The changes increment the Kubernetes application's chart version, update its version mapping with a new commit reference, and modify the ingress-nginx HelmRelease template to conditionally disable the cert-manager admission webhook when the cert-manager addon is not enabled.
Changes
| Files/Paths | Change Summary |
|---|---|
| packages/apps/kubernetes/Chart.yaml | Bumped chart version from 0.20.0 to 0.20.1. |
| packages/apps/versions_map | Updated kubernetes version 0.20.0 commit reference and added 0.20.1 with HEAD. |
| packages/apps/kubernetes/templates/helmreleases/ingress-nginx.yaml | Added conditional logic to disable cert-manager admission webhook if cert-manager addon is not enabled. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant Helm Chart
participant Values
participant Ingress-NGINX Controller
User->>Helm Chart: Deploy/upgrade ingress-nginx
Helm Chart->>Values: Check .addons.certManager.enabled
alt certManager enabled
Ingress-NGINX Controller->>Ingress-NGINX Controller: admissionWebhooks.certManager enabled
else certManager not enabled
Ingress-NGINX Controller->>Ingress-NGINX Controller: admissionWebhooks.certManager disabled
end
Suggested labels
ok-to-test
Suggested reviewers
- lllamnyp
Poem
A chart hops up from 0.20.0 to one,
With version maps and hashes spun.
If cert-manager’s not around to play,
The webhook quietly hops away.
Helm templates checked, the fields align—
Another patch, another sign!
🐇✨
[!NOTE]
⚡️ AI Code Reviews for VS Code, Cursor, Windsurf
CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.
[!NOTE]
⚡️ Faster reviews with caching
CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure
Review - Disable Cacheat either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off theData Retentionsetting under your Organization Settings. Enjoy the performance boost—your workflow just got faster.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.