[build] Cross-arch builds: core/installer
core/installer is updated to support multiple architectures
Part of #519
Summary by CodeRabbit
- New Features
- Added full support for ARM64 architecture, including building, tagging, and pushing Talos-related images and assets.
- Introduced ARM64-specific Talos installer profiles and assets for various deployment formats (ISO, raw image, kernel, initramfs, nocloud).
- Enhanced Docker images and build scripts to support multi-architecture builds and cross-compilation.
- Chores
- Improved build scripts and Makefile for dynamic architecture handling and stricter error checking.
- Standardized Dockerfile syntax and asset management for consistency across architectures.
"""
Walkthrough
This change introduces comprehensive multi-architecture (amd64 and arm64) support to the Talos installer build and release process. It generalizes scripts, Makefile targets, Dockerfiles, and asset upload logic to dynamically handle both architectures, and adds new ARM64-specific Talos installer profile YAMLs for all supported asset types.
Changes
| File(s) | Change Summary |
|---|---|
| hack/upload-assets.sh | Modified to upload ARM64 assets alongside AMD64 during GitHub release. Each asset type now uploads both architectures. |
| packages/core/installer/Makefile | Refactored to support multi-architecture builds and asset management for amd64 and arm64. Targets, variables, and Docker build commands now dynamically handle architectures. Asset and image build rules are generalized and new pattern rules are introduced. |
| packages/core/installer/hack/gen-profiles.sh packages/core/installer/hack/gen-versions.sh |
Both scripts now accept architecture as an argument, default to amd64, echo the chosen architecture, and use architecture overrides in all skopeo commands. Profile and version outputs are architecture-specific. Strict error handling is added to gen-versions.sh. |
| packages/core/installer/images/cozystack/Dockerfile | Standardized AS keyword casing, added TARGETOS and TARGETARCH build args, and set GOOS/GOARCH for cross-compilation. Ensured all APK installs use --no-cache. |
| packages/core/installer/images/matchbox/Dockerfile | Introduced TARGETARCH build arg and used it to copy architecture-specific kernel and initramfs assets. |
| packages/core/installer/images/talos/profiles/initramfs-arm64.yaml installer-arm64.yaml iso-arm64.yaml kernel-arm64.yaml metal-arm64.yaml nocloud-arm64.yaml |
Added new ARM64-specific Talos installer profile YAMLs for all asset types (initramfs, installer, iso, kernel, metal, nocloud). These profiles are auto-generated and support building ARM64 assets. |
Sequence Diagram(s)
sequenceDiagram
participant Developer
participant Makefile
participant gen-profiles.sh
participant gen-versions.sh
participant Docker Buildx
participant GitHub Release
Developer->>Makefile: make assets / make image-talos
Makefile->>gen-profiles.sh: Generate profiles for amd64 and arm64
Makefile->>gen-versions.sh: Fetch versions for amd64 and arm64
Makefile->>Docker Buildx: Build images for both architectures
Makefile->>Makefile: Assemble multi-arch manifests
Makefile->>hack/upload-assets.sh: Upload assets for both amd64 and arm64
hack/upload-assets.sh->>GitHub Release: Upload all assets (amd64, arm64)
Possibly related PRs
- cozystack/cozystack#773: Adds AMD64 kernel and initramfs uploads; this PR generalizes that approach to both AMD64 and ARM64.
- cozystack/cozystack#907: Enhances Docker image builds for multi-architecture with dynamic platform specification; related in build system improvements.
Suggested labels
ok-to-test
Suggested reviewers
- kvaps
- lllamnyp
Poem
In the warren of code, two arches arise,
Arm and x86, now both win the prize.
Scripts and profiles, Docker builds anew,
Rabbits hop swiftly, supporting more crew.
With every .yaml, a future unrolled—
Multi-arch dreams in CI burrows unfold! 🐇✨ """
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
All Makefile targets are tested.
Talos profile versions are equal to ones in main.
@nbykov0 hey, could you please squash commits before the merge?
@nbykov0 hey, could you please squash commits before the merge?
Done