cozystack icon indicating copy to clipboard operation
cozystack copied to clipboard

Published 20 hours ago • verified publisher icon aenix-io

Introduce InstanceTypes

Open kvaps opened this issue 1 year ago • 1 comments

This PR introduces the default instancetypes:

  • cx1.2xlarge
  • cx1.4xlarge
  • cx1.8xlarge
  • cx1.large
  • cx1.medium
  • cx1.xlarge
  • gn1.2xlarge
  • gn1.4xlarge
  • gn1.8xlarge
  • gn1.xlarge
  • m1.2xlarge
  • m1.4xlarge
  • m1.8xlarge
  • m1.large
  • m1.xlarge
  • n1.2xlarge
  • n1.4xlarge
  • n1.8xlarge
  • n1.large
  • n1.medium
  • n1.xlarge
  • o1.2xlarge
  • o1.4xlarge
  • o1.8xlarge
  • o1.large
  • o1.medium
  • o1.micro
  • o1.nano
  • o1.small
  • o1.xlarge
  • rt1.2xlarge
  • rt1.4xlarge
  • rt1.8xlarge
  • rt1.large
  • rt1.medium
  • rt1.micro
  • rt1.small
  • rt1.xlarge
  • u1.2xlarge
  • u1.2xmedium
  • u1.4xlarge
  • u1.8xlarge
  • u1.large
  • u1.medium
  • u1.micro
  • u1.nano
  • u1.small
  • u1.xlarge

And the following profiles:

  • alpine
  • centos.7
  • centos.7.desktop
  • centos.stream10
  • centos.stream10.desktop
  • centos.stream8
  • centos.stream8.desktop
  • centos.stream8.dpdk
  • centos.stream9
  • centos.stream9.desktop
  • centos.stream9.dpdk
  • cirros
  • fedora
  • fedora.arm64
  • opensuse.leap
  • opensuse.tumbleweed
  • rhel.10
  • rhel.10.arm64
  • rhel.7
  • rhel.7.desktop
  • rhel.8
  • rhel.8.desktop
  • rhel.8.dpdk
  • rhel.9
  • rhel.9.arm64
  • rhel.9.desktop
  • rhel.9.dpdk
  • rhel.9.realtime
  • sles
  • ubuntu
  • windows.10
  • windows.10.virtio
  • windows.11
  • windows.11.virtio
  • windows.2k16
  • windows.2k16.virtio
  • windows.2k19
  • windows.2k19.virtio
  • windows.2k22
  • windows.2k22.virtio
  • windows.2k25
  • windows.2k25.virtio

as part of https://github.com/aenix-io/cozystack/issues/258

Summary by CodeRabbit

  • New Features

    • Introduced new instance types and preferences for Virtual Machines.
    • Added new sections in the documentation for better clarity on series and parameters.
    • Enhanced resource management with new fields for CPU and memory specifications.

  • Bug Fixes

    • Corrected indentation issues in configuration files.

  • Documentation

    • Updated README files with new parameters and sections for improved user guidance.

  • Chores

    • Version updates across various components to ensure compatibility and access to the latest features.

kvaps avatar Oct 08 '24 14:10 kvaps

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request includes multiple updates across various packages, primarily focusing on version increments for Kubernetes and virtual-machine components. Significant changes encompass the addition of new sections in README files, modifications to YAML configurations introducing new parameters and fields, and the creation of new charts for kubevirt-common-instancetypes and vm-disk. Additionally, several properties in configuration files have been updated or removed to improve resource management.

Changes

File Path Change Summary
packages/apps/kubernetes/Chart.yaml Version updated from 0.12.0 to 0.13.0.
packages/apps/kubernetes/README.md Section renamed and multiple new sections added for various series.
packages/apps/kubernetes/templates/cluster.yaml New fields (instancetype, cpu, memory) and annotations added in MachineDeployment.
packages/apps/kubernetes/values.yaml Parameter resources updated; removed cpu and memory, added instanceType and new resources.
packages/apps/versions_map Multiple version updates for Kubernetes, virtual-machine, and MySQL components.
packages/apps/virtual-machine/Chart.yaml Version updated from 0.4.0 to 0.5.0.
packages/apps/virtual-machine/README.md New parameters added and existing parameters modified.
packages/apps/virtual-machine/hack/update-instance-types.sh New file created.
packages/apps/virtual-machine/templates/vm.yaml New conditional checks and fields added, with updates to storage handling.
packages/apps/virtual-machine/values.schema.json Property renamed and new properties added; existing properties updated.
packages/apps/virtual-machine/values.yaml Parameters removed, added, and modified for instance types and resources.
packages/system/kubevirt-common-instancetypes/Chart.yaml New chart added with apiVersion: v2.
packages/system/kubevirt-common-instancetypes/Makefile Variables added for namespace and name.
packages/system/kubevirt-common-instancetypes/templates/instancetypes.yaml New instance types added.
packages/system/kubevirt-common-instancetypes/templates/preferences.yaml New resources added for various operating systems.
packages/system/kubevirt-common-instancetypes/values.yaml New file created.
packages/apps/vm-disk/Chart.yaml New chart added with apiVersion: v2, name: vm-disk, and version 0.1.0.
packages/apps/vm-disk/Makefile New target added for README generation.
packages/apps/vm-disk/README.md Detailed README document outlining deployment details and parameters.
packages/apps/vm-disk/hack/update-instance-types.sh New file created.
packages/apps/vm-disk/templates/NOTES.txt Conditional section added for disk image upload instructions.
packages/apps/vm-disk/templates/dashboard-resourcemap.yaml Role added for managing access control.
packages/apps/vm-disk/templates/dv.yaml New resource defined for KubeVirt and CDI.
packages/apps/vm-disk/templates/pvc-resize-hook.yaml Job and ServiceAccount added for resizing PVCs.
packages/apps/vm-disk/values.schema.json New schema added for defining chart values related to VM disk configurations.
packages/apps/vm-disk/values.yaml New section and parameters added for common configurations.
packages/apps/vm-instance/.helmignore New file created specifying paths to ignore during Helm packaging.
packages/apps/vm-instance/Chart.yaml Version updated from 0.4.0 to 0.1.0 and name changed to vm-instance.
packages/apps/vm-instance/Makefile New target added for README generation.
packages/apps/vm-instance/README.md Detailed README file explaining function and deployment details.
packages/apps/vm-instance/hack/update-instance-types.sh New file created.
packages/apps/vm-instance/templates/vm.yaml New template added with validation checks for instance types and profiles.
packages/apps/vm-instance/values.schema.json New schema added for defining chart values related to VM instances.
packages/apps/vm-instance/values.yaml Parameters removed, added, and modified for instance types and resources.
packages/core/platform/bundles/paas-full.yaml New release added for kubevirt-instancetypes with dependencies on various components.
packages/system/kubevirt-instancetypes/Chart.yaml New Helm chart file added for cozy-kubevirt-instancetypes.
packages/system/kubevirt-instancetypes/Makefile New Makefile for managing KubeVirt instance types with variables: NAME and NAMESPACE.
packages/system/kubevirt-instancetypes/templates/instancetypes.yaml New YAML configuration defining multiple VirtualMachineClusterInstancetype resources.
packages/system/kubevirt-instancetypes/templates/preferences.yaml New YAML configuration defining VirtualMachineClusterPreference resources.
packages/system/kubevirt-instancetypes/values.yaml New file created.

Possibly related PRs

  • #403: This PR introduces instance types and profiles that are directly related to the changes made in the main PR, which also includes updates to the Chart.yaml, cluster.yaml, and values.yaml files for Kubernetes applications, specifically focusing on instance types and resource specifications.

🐰 In the meadow, changes bloom,
New versions rise, dispelling gloom.
With parameters fresh and bright,
Our Kubernetes takes flight!
Virtual machines, now more refined,
In cozy charts, new paths we find.
Hooray for updates, let joy abound! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 08 '24 14:10 coderabbitai[bot]