aenix-io
Flux Operator 0.7
A new release of Flux Operator is out, it covers:
- https://github.com/controlplaneio-fluxcd/flux-operator/issues/51
which previously affected us.
~We can now ship the FluxInstance with an empty spec.cluster so cluster/tenant users are free to override it themselves.~ I don't think that 3-way merge is the right way to set cluster, but good news that Flux Operator has released an upstream flux-instance chart with json schema and full coverage of the spec for a FluxInstance, we can use it now and abandon our hand-crafted template. The 3-way merge will still work for users who want to set spec.sync from inside the tenant cluster. I think there is a better way to set that up within the HelmRelease values now, but both options remain viable.
(Downstream users could override any fields they wanted before, so long as they weren't trying to set networkPolicy because we would just set it back next time the installer ran from the top. Now with this change, it can be free-for-all. On the other hand with the new chart from upstream, we are not free to leave cluster setting unset, it's clarified that they all imply a default value. We should look into setting cluster.domain and think about removing some of our patches.)
There's no urgency to have this backported into the 0.8 release, since we did work around it, I don't think it's a high impact change, but the wrong default did affect us once before, so here we go! No longer needed to work around it.
I wonder if we should expand the FluxInstance chart, actually I think there may be an upstream chart we can use now that is more full-featured and we won't have to maintain it. 🤞 Let me look into these things, marking the PR as a draft.
We should look at this new artifact feature and understand exactly what it does, I'm pretty sure it's designed so that end-users do not have to upgrade flux-operator after Flux is released in order to get the latest Flux release, but we should be sure of what it's doing to understand that it does not conflict with our cozystack installer-based reconciler.
There is Flux Operator 0.9 now, I will submit a new pull request bringing it up to date today