Adrian Hartanto

Results 21 comments of Adrian Hartanto
trafficstars

hi @wyattjoh, could you please help to review this PR? let me know what you think 🙏

got it, updated the swr value for ISR to 1 year, cc @shuding @ijjk

@ijjk do you have suggestion how to test it? was checked running production build locally, there seems no difference. as for case with CDN, tested in Cloudfront, it allows Cloudfront...

thanks for the confirmation @ijjk !

reverted `/gssp` test value as `swr` is not defined https://github.com/vercel/next.js/blob/canary/test/production/standalone-mode/required-server-files/pages/gssp.js#L8 @ijjk

could you help to re-run the CI checks @ijjk ? also not sure why its failing on prefetch test

its failed to set up the runner now

hi @ijjk , just adjusted some tests on prefetching, could you help to re-run the tests? changes on #61794 looks like related with rsc payload that impacting the tests

hi @ijjk, - just removed `rsc` test case on this [commit](https://github.com/vercel/next.js/pull/61330/commits/570ec4952b692e3564251b3b98b8d8bedd014fc6), due to changes on #61794 and #61235 that removes `next-url` changes that was added on #52746, kindly help to...

do you mean adding new option to define swr on ISR pages @ijjk ? ex: { revalidate: 600, staleWhileRevalidate: 6000, }