SparseConnectivityTracer.jl icon indicating copy to clipboard operation
SparseConnectivityTracer.jl copied to clipboard

Allow more generic hessian set types

Open gdalle opened this issue 1 year ago • 1 comments

gdalle avatar May 24 '24 10:05 gdalle

Codecov Report

Attention: Patch coverage is 89.86486% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.19%. Comparing base (59ae75c) to head (2b64b8c). Report is 1 commits behind head on main.

Files Patch % Lines
src/settypes/recursiveset.jl 33.33% 8 Missing :warning:
src/overload_connectivity.jl 87.50% 3 Missing :warning:
src/settypes/duplicatevector.jl 80.00% 2 Missing :warning:
src/overload_hessian.jl 97.22% 1 Missing :warning:
src/tracers.jl 93.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   84.56%   84.19%   -0.37%     
==========================================
  Files          18       18              
  Lines         758      829      +71     
==========================================
+ Hits          641      698      +57     
- Misses        117      131      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 24 '24 14:05 codecov-commenter

@adrhill can you take a look and validate the general direction?

gdalle avatar May 30 '24 10:05 gdalle

The benchmark failures are caused by UInt64, please merge #109 first

gdalle avatar May 31 '24 08:05 gdalle

#109 has been merged.

adrhill avatar May 31 '24 09:05 adrhill