aqa-tests
aqa-tests copied to clipboard
Remove native compiler dependency in system tests
Native compilation in system tests resulted in many complications when setting up the testing environment.
For example, we need to have the correct compiler installed. xlC is /opt/IBM/xlC/13.1.3/bin (we no longer support it), but it's on the path. xlclang is /opt/IBM/xlC/16.1.0/bin, which isn't on the path. Also, Visual Studio is expected on Windows with specific versions/path.
Talked with @pshipton , and we think we should simplify system tests by removing the native compiler dependency.
ToDo:
- [x] Remove com.test.jlink from system test https://github.com/adoptium/aqa-systemtest/tree/master/openjdk.test.modularity/src/tests/com.test.jlink. If this test is important, we can contribute it to OpenJDK if needed.
- [ ] Move
SharedClassesAPInative code into OpenJ9, and stop building it in the tests. https://github.com/adoptium/aqa-tests/blob/9776620cc838d27813365c534a2639a5dced4b92/system/sharedClasses/playlist.xml#L26 - [ ] Ensure we do not have any other native compilation in system tests (i.e., all
build-natives-xxxshould be empty) - [ ] ~Inform infra team to remove native compiler as part of the test env setup requirement.~ We still need it for non-system tests.
@annaibm could you take a look at this issue? Thanks
In OpenJDK I see test/jdk/tools/jlink, not sure if we are running these tests.
FYI
/opt/IBM/xlC/16.1.0/bin has both xlC and xlclang. OpenJ9 builds no longer use xlC, or 13.1.3 compilers.
13.1.3 is on the path on some machines, but since AIX 7.3 doesn't support it, I expect 16.1.0 is on the path on AIX 7.3 machines.
@llxia
Removed the com.test.jlink from the system test com.test.jlink directory and made related build.xml changes that depended on com.test.jlink.
Draft PR: adoptium/aqa-systemtest#498
Had to exclude the following tests as shown in the Draft PR: adoptium/aqa-tests#5992 as the sanity.system test failed for the jlink tests.
Sanity.system test failure (without excluding jlink tests): Grinder #48246
Disabled Tests: (can remove the tests if its not needed)
TESTLIST=Jlink_ReqMod,Jlink_AddMLimitM,Jlink_GenOpt
Test run after exclusions: Grinder #48400
Sanity.system test run passed Grinder #48446
I believe we should also remove Jlink_ReqMod,Jlink_AddMLimitM and Jlink_GenOpt from playlist.xml
I believe we also should remove https://github.com/adoptium/STF/blob/03f6cc21c7356c036ccd11173c061417f58b621b/stf.build/include/top.xml#L102
Thanks @annaibm . This issue is completed.