lucid icon indicating copy to clipboard operation
lucid copied to clipboard

db:seed and migration:fresh use default connection, and not that supplied by the --connection flag

Open ghost opened this issue 1 year ago • 4 comments

Package version

18.4.2

Describe the bug

Running ace db:seed and ace migration:fresh seems to ignore the --connection flag. ace db:wipe and ace migration:run respect the connection flag as expected.

Reproduction repo

No response

ghost avatar Feb 05 '24 12:02 ghost

Worked out the issue somewhat - the connection info isn’t being passed to any of the functions in the seeders’ run() methods.

ghost avatar Feb 05 '24 22:02 ghost

Can you please create a PR for the same. It should be created for the v18 branch. https://github.com/adonisjs/lucid/tree/v18

thetutlage avatar Feb 06 '24 03:02 thetutlage

He deleted his account.

I have added the flag Good First Issue if anyone want to make a contribution!

RomainLanz avatar Feb 15 '24 11:02 RomainLanz

In fact, I believe this PR may fix the issue: https://github.com/adonisjs/lucid/pull/983

RomainLanz avatar Feb 15 '24 11:02 RomainLanz

Did it indeed fix the issue? Or is this still something that should be looked at? :-)

aarhusgregersen avatar Mar 28 '24 14:03 aarhusgregersen

Yes, it did. Also, feel free to give it a try and report back if the issue persists

thetutlage avatar Apr 01 '24 05:04 thetutlage