spectrum-tokens icon indicating copy to clipboard operation
spectrum-tokens copied to clipboard

Fixed bug in compare card when sharing url of report

Open shirlsli opened this issue 1 year ago • 2 comments

Description

Implemented sharing via url for the diff generator website. The user is now able to send a link of their report to others and they'll be able to view the report without manually re-selecting the parameters.

Motivation and Context

My previous approach to handling the passing of parameters into the compare card component was very buggy, so I switched to having the compare card component read in parameters from the url instead of from its parent component.

How Has This Been Tested?

Currently there has only been manual testing done by me.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

shirlsli avatar Jul 30 '24 18:07 shirlsli

⚠️ No Changeset found

Latest commit: 5681af2e350a4cd042047ca90a437e3c557f45f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 30 '24 18:07 changeset-bot[bot]

Run report for 5681af2e

Total time: 17.4s | Comparison time: 22.8s | Estimated savings: 5.3s (23.4% faster)

Action Time Status Info
🟩 SyncWorkspace 4.7ms Passed
⬛️ SetupToolchain(node:~20.12) 1.3s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 SyncProject(node, tdiff) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 10.6s Passed
🟩 RunTask(diff:diff) 121.6ms Passed
🟩 RunTask(root:test) 2.1s Passed
🟥 RunTask(tdiff:typescript) 5s Failed
⬛️ RunTask(tdiff:build) 0.2ms Skipped
🟩 RunTask(diff:test) 5.5s Passed
Touched files
docs/token-diff/index.d.ts
docs/token-diff/package.json
docs/token-diff/src/CodePanel.ts
docs/token-diff/src/CompareCard.ts
docs/token-diff/src/DiffReport.ts
docs/token-diff/src/GettingStarted.ts
docs/token-diff/src/NavBar.ts
docs/token-diff/src/PageContainer.ts
docs/token-diff/src/TokenDiff.ts
docs/token-diff/src/fetchFromGithub.ts
docs/token-diff/tsconfig.json
pnpm-lock.yaml
tools/diff-generator/src/lib/added-token-detection.js
tools/diff-generator/src/lib/cli.js
tools/diff-generator/src/lib/format-function.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap

GarthDB avatar Jul 30 '24 18:07 GarthDB