spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

Published 20 hours ago • verified publisher icon adobe

Update peer deps for breadcrumb

Open GarthDB opened this issue 3 years ago • 1 comments

Description

Breadcrumb had the incorrect version for actionbutton it peer deps so it was throwing an error/warning.

How and where has this been tested?

  • Built locally

To-do list

  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [x] This pull request is ready to merge.

GarthDB avatar Aug 17 '22 15:08 GarthDB

🚀 Deployed on https://pr-1499--spectrum-css.netlify.app

github-actions[bot] avatar Aug 17 '22 15:08 github-actions[bot]

@GarthDB is this PR still relevant - @pfulton do you want me to review & merge?

castastrophe avatar Dec 16 '22 15:12 castastrophe

So, is this happening because we have a batch of components that have been migrated to the new tokens system, and some that haven't, and some of the ones that have been migrated are dependencies of those that have not yet been migrated?

pfulton avatar Dec 16 '22 16:12 pfulton

@pfulton @GarthDB On closer inspection, I believe the error has more to do with how peer dependencies are being defined across the repo. Typically they are more permissive and leverage the >= syntax to allow some flexibility in definition. This is a benefit because it will lead to less version management struggles downstream. I think we should tackle this on every component. What do you think?

castastrophe avatar Jan 03 '23 15:01 castastrophe

I think I'll close this PR out for now in favor of a wholistic solution. I created CSS-381 to track that work.

castastrophe avatar Jan 12 '23 17:01 castastrophe