react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

TS Strict Collections

Open snowystinger opened this issue 1 year ago โ€ข 11 comments

Closes

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger avatar Jun 18 '24 03:06 snowystinger

## API Changes

@react-stately/collections

/@react-stately/collections:PartialNode

 PartialNode <T> {
   aria-label?: string
   childNodes?: () => IterableIterator<PartialNode<T>>
   element?: ReactElement
   hasChildNodes?: boolean
   index?: number
-  key?: Key
+  key?: Key | null
   props?: any
   rendered?: ReactNode
   renderer?: (T) => ReactElement
   shouldInvalidate?: (unknown) => boolean
   type?: string
   value?: T
   wrapper?: (ReactElement) => ReactElement
 }

/@react-stately/collections:CollectionBuilder

 CollectionBuilder <T extends {}> {
-  build: (CollectionBase<{}>, unknown) => void
+  build: (Partial<CollectionBase<{}>>, unknown) => void
 }

rspbot avatar Oct 14 '24 06:10 rspbot

closing for https://github.com/adobe/react-spectrum/pull/7368

snowystinger avatar Nov 15 '24 07:11 snowystinger