react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

fix: controlled tooltips are not close properly

Open igorman007 opened this issue 1 year ago โ€ข 3 comments

Closes #6233

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

You can check this fix at storybook page. http://localhost:9003/?path=/story/tooltiptrigger--controlled-multiple-tooltips&providerSwitcher-express=false&strict=true

before: the first tooltip doesn't close, when the second opens after: the first tooltip closes, when the second opens

๐Ÿงข Your Project:

igorman007 avatar May 20 '24 10:05 igorman007

Thanks for the PR! Mind signing the Adobe CLA?

yihuiliao avatar May 20 '24 17:05 yihuiliao

Thanks for the PR! Mind signing the Adobe CLA?

Done

igorman007 avatar May 20 '24 18:05 igorman007

Also, if it's not too hard, would you mind adding a unit test?

snowystinger avatar May 21 '24 03:05 snowystinger

GET_BUILD

LFDanLu avatar May 23 '24 22:05 LFDanLu

## API Changes

unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' }

rspbot avatar May 23 '24 23:05 rspbot

That's great! May I ask when this fix will be published?

GuoXiaoyang avatar Jun 04 '24 03:06 GuoXiaoyang

It'll be in our next release. Sometime in the next couple weeks most likely

snowystinger avatar Jun 04 '24 04:06 snowystinger