react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Update to Node 20

Open snowystinger opened this issue 1 year ago โ€ข 12 comments

Closes https://github.com/adobe/react-spectrum/issues/6380

Not sure why, but the SSR tests are super brittle now. In addition, I haven't gotten the make website-production working locally, would love someone else to run those as well. Just make sure every terminal you open is set to node 20.15.0

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger avatar May 15 '24 05:05 snowystinger

EDIT: Got the following error when running make website-production, I assume that was expected from the comment in your description?

yep, that's the same one I was getting. I'm not sure why the resolver isn't working...

snowystinger avatar Oct 16 '24 00:10 snowystinger