react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Published 20 hours ago • verified publisher icon adobe

Toast focus management take 2

Open snowystinger opened this issue 1 year ago • 21 comments

Closes

In association with https://github.com/adobe/react-spectrum/pull/6011

✅ Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test instructions in https://github.com/adobe/react-spectrum/pull/6011 description

🧢 Your Project:

snowystinger avatar Apr 17 '24 20:04 snowystinger

Build successful! 🎉

rspbot avatar Apr 23 '24 13:04 rspbot

Build successful! 🎉

rspbot avatar Apr 29 '24 14:04 rspbot

Build successful! 🎉

rspbot avatar Apr 30 '24 15:04 rspbot

Build successful! 🎉

rspbot avatar May 02 '24 19:05 rspbot

Build successful! 🎉

rspbot avatar May 03 '24 01:05 rspbot

Build successful! 🎉

rspbot avatar May 03 '24 18:05 rspbot

Build successful! 🎉

rspbot avatar May 08 '24 07:05 rspbot

@snowystinger With recent changes, focus is getting lost to the document.body when the top toast, the last item in the list gets removed and other toasts remain.

majornista avatar May 09 '24 13:05 majornista

Build successful! 🎉

rspbot avatar May 09 '24 15:05 rspbot

@snowystinger With recent changes, focus is getting lost to the document.body when the top toast, the last item in the list gets removed and other toasts remain.

thanks for the identification and fix, I've added a test case to cover the behavior

snowystinger avatar May 10 '24 02:05 snowystinger

Build successful! 🎉

rspbot avatar May 10 '24 02:05 rspbot

Build successful! 🎉

rspbot avatar May 10 '24 02:05 rspbot

Build successful! 🎉

rspbot avatar May 10 '24 04:05 rspbot

Build successful! 🎉

rspbot avatar May 16 '24 00:05 rspbot

Build successful! 🎉

rspbot avatar May 16 '24 21:05 rspbot

Build successful! 🎉

rspbot avatar May 20 '24 08:05 rspbot

Build successful! 🎉

rspbot avatar May 20 '24 08:05 rspbot

Build successful! 🎉

rspbot avatar May 20 '24 23:05 rspbot

Build successful! 🎉

rspbot avatar May 21 '24 00:05 rspbot

Build successful! 🎉

rspbot avatar May 21 '24 20:05 rspbot

Build successful! 🎉

rspbot avatar May 22 '24 23:05 rspbot

Build successful! 🎉

rspbot avatar May 24 '24 02:05 rspbot

Build successful! 🎉

rspbot avatar May 24 '24 02:05 rspbot

Yeah, we should update the hooks docs, followup https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=65286699 Starting branch here: https://github.com/adobe/react-spectrum/pull/6468

snowystinger avatar May 30 '24 05:05 snowystinger

Build successful! 🎉

rspbot avatar May 30 '24 05:05 rspbot

## API Changes

unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' }

@react-aria/toast

ToastAria

 ToastAria {
   closeButtonProps: AriaButtonProps
+  contentProps: DOMAttributes
   descriptionProps: DOMAttributes
   titleProps: DOMAttributes
   toastProps: DOMAttributes
 }

it changed:

  • useToast

rspbot avatar May 30 '24 05:05 rspbot