react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Update useListState.ts

Open Develekko opened this issue 1 year ago โ€ข 8 comments

fixing error : Cannot read properties of undefined (reading 'index')

Closes https://github.com/adobe/react-spectrum/issues/5817

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

Develekko avatar Feb 06 '24 08:02 Develekko

GET_BUILD

reidbarber avatar Feb 06 '24 17:02 reidbarber

## API Changes

unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' }

rspbot avatar Feb 06 '24 18:02 rspbot

I'd like to get a test for this change if possible.

snowystinger avatar Apr 10 '24 03:04 snowystinger

Hi, When will this pr merge?

CurryYangxx avatar Aug 01 '24 03:08 CurryYangxx

Would you be able to provide a reproduction for the error? I'm worried something else is going on that we're going to be hiding.

snowystinger avatar Aug 01 '24 03:08 snowystinger

I can't yet. I am trying to found out how to reproduce. Could you guess how the error might be reproduced based on the error?

CurryYangxx avatar Aug 01 '24 06:08 CurryYangxx

The only things I see causing it are the cachedCollection becoming stale or the focusedKey is wrong somehow. Either way, I want to know if one of those things is happening because that seems like those might lead to other issues.

snowystinger avatar Aug 01 '24 22:08 snowystinger