react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Breaking change in 3.22.0, making Validate interface require a parameter

Open romulof opened this issue 1 year ago โ€ข 0 comments

Provide a general summary of the issue here

This breaking change was introduced in 3.22.0 of @react-types/shared:

https://github.com/adobe/react-spectrum/pull/5288/files#r1463390004

The interface Validate now requires a parameter.

Example where it broke: https://github.com/project44/manifest/blob/main/packages/react/src/components/FormControl/FormControl.tsx#L14

๐Ÿค” Expected Behavior?

A bump in minor version should not cause breaking changes.

๐Ÿ˜ฏ Current Behavior

Bumping from 3.21.0 to 3.22.0 caused a breaking change.

๐Ÿ’ Possible Solution

Those additional properties added to Validate interface should have been added on another layer, keeping Validate backwards compatible.

๐Ÿ”ฆ Context

No response

๐Ÿ–ฅ๏ธ Steps to Reproduce

https://github.com/project44/manifest/blob/main/packages/react/src/components/FormControl/FormControl.tsx#L14

Version

3.22.0

What browsers are you seeing the problem on?

Other

If other, please specify.

Browser independent

What operating system are you using?

macOS

๐Ÿงข Your Company/Team

No response

๐Ÿ•ท Tracking Issue

No response

romulof avatar Jan 23 '24 14:01 romulof