react-spectrum
react-spectrum copied to clipboard
adobe
DNM Tsdiffer tests and fixes
Closes
Introduces tests for TSDiffer to make debugging easier. This is based heavily on the tests for the DocsTransformer. I fixed some of the bugs I was aware of while writing tests.
Easiest way to test this is to run the script target check-published-apis and just make sure those changes make sense.
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
## API Changes
unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'HTMLAttributes', imported: 'HTMLAttributes', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'ReactDOM', imported: 'ReactDOM', specifier: 'react' } unknown type { type: 'reference', local: 'DOMFactory', imported: 'DOMFactory', specifier: 'react' } unknown type { type: 'reference', local: 'HTMLAttributes', imported: 'HTMLAttributes', specifier: 'react' } unknown type { type: 'reference', local: 'SpectrumColumnProps', imported: 'SpectrumColumnProps', specifier: '@react-types/table' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Theme', imported: 'Theme', specifier: '@react-types/provider' } unknown type { type: 'reference', local: 'Direction', imported: 'Direction', specifier: '@react-types/shared' } unknown type { type: 'reference', local: 'Direction', imported: 'Direction', specifier: '@react-types/shared' } unknown type { type: 'reference', local: 'Direction', imported: 'Direction', specifier: '@react-types/shared' } unknown type { type: 'reference', local: 'Direction', imported: 'Direction', specifier: '@react-types/shared' } unknown type { type: 'reference', local: 'ValidationResult', imported: 'ValidationResult', specifier: '@react-types/shared', description: null } unknown type { type: 'reference', local: 'ValidationResult', imported: 'ValidationResult', specifier: '@react-types/shared', description: null }
packages/@react-spectrum/table/src/index.ts:SpectrumColumn
@react-spectrum/table/src/index.ts:SpectrumColumn
-Column<T> {
- props: ColumnProps<T>
- returnVal: ReactElement
-}
+Column: (unknown type<T>) => JSX.Element
closing in favor of https://github.com/adobe/react-spectrum/pull/6736 and i'll likely open others for anything else in here