react-spectrum
react-spectrum copied to clipboard
adobe
Custom resize cursors
Closes
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
Build successful! 🎉
What's the plan for the aria hooks? Will we somehow fall back to the standard ones? Embed these?
What's the plan for the aria hooks? Will we somehow fall back to the standard ones? Embed these?
I decided to move it out entirely, there's enough information coming from the hook to set whatever cursor you want. Reason being that it seemed like a rendering concern more than aria. Especially since you need to set the cursor on hover as well as setting the entire document, every element, with !important during drag. Without creating a stylesheet on the fly, setting it for every element would be impossible.
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
The most recent storybook v18 build isn't showing the new cursor. It is showing a cursor, but it doesn't look like the one I see in files nor the first version of storybook with this PR.
Build successful! 🎉
Build successful! 🎉
I didn't consider what Daniel reported as an issue, but since we are this doesn't seem right. Give it keyboard focus and then mouse over it.
I didn't consider what Daniel reported as an issue, but since we are this doesn't seem right. Give it keyboard focus and then mouse over it.
Will be fixed by https://github.com/adobe/react-spectrum/pull/3560
update: fixed
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉