react-spectrum
react-spectrum copied to clipboard
adobe
Do not uppercase table headers
Closes
One thing to note, on overflow wrap tables, the headers have now gotten taller by 4px because we start with an estimated height and then calculate after render the actual height.
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
Build successful! 🎉
Looking at https://spectrum.adobe.com/page/table/, I think the font size looks too big, and the color looks too dim.
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Where are the accordion XD files? I'm sure the larger and darker side is desired it just looks weird. I wanted to check the chevron because the open state seems too low. Probably not a priority since this is alpha and main work is being done by Quarry.
Where are the accordion XD files? I'm sure the larger and darker side is desired it just looks weird. I wanted to check the chevron because the open state seems too low. Probably not a priority since this is alpha and main work is being done by Quarry.
accordion xd are in the contributions site
Is this the same issue I'm seeing where the sort direction indicator looks darker in the XD file and v5 colors says it should be #6d6d6, closest Spectrum being gray-700, but we're using #8e8e8e/rgb(142,142,142). When I look at the spectrum token of that color we're using gray-600, which isn't gray-700.
Sort icon was wrong, should be gray-800 like the text, on hover they become gray-900
Build successful! 🎉
Build successful! 🎉