react-spectrum
react-spectrum copied to clipboard
WIP add steplist componente
Closes
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
I took the great work @itaylor did on step list and did some of the changes that were discussed like:
- changed
ariahooks to fallow samepattern, like the rest of the components passingpropsstaterefto get the componentsDOMprops - added
keyboarddelegation foruseStepListcurrently it's the same like fortabsbut i will fallow withspectrumdesign to get the corectkeyboardnavigation behaviour - added support for
useSelectableCollectioninuseStepList - moved
aria-${props}out ofuseStepItemtoStepItemto fallow the same pattern with the rest of the components
My Plan:
- revisit
stylingand make sure we are aligned withUX - address some comments from @snowystinger regarding
flex - add docs
- refactor
storiesand add more examples
Let me know your thoughts