react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Published 20 hours ago • verified publisher icon adobe

Clean up usePress code

Open devongovett opened this issue 4 years ago • 5 comments

  1. ~~We can probably get rid of the fallback events (mouse/touch) now since all supported browsers support pointer events.~~ https://github.com/adobe/react-spectrum/discussions/5636#discussioncomment-8053511 is why we can't get rid of the fall backs
  2. Clean up the various states to simplify the code.
  3. Possibly get rid of the custom hit testing. The code comment indicates that this was for iOS < 13.2 which is long gone, so possibly this isn't needed anymore. We will need to do some testing. Related: #1061 #1613

devongovett avatar Mar 19 '21 23:03 devongovett

Hi all, is this being taken into consideration?

cpatti97100 avatar Feb 12 '24 11:02 cpatti97100

Yes, however, it has some nuances that we'll need to account for, see https://github.com/adobe/react-spectrum/discussions/5636#discussioncomment-8053511

feel free to make a PR for it

snowystinger avatar Feb 12 '24 20:02 snowystinger

Would be great if a fix is introduced

https://github.com/adobe/react-spectrum/issues/5290

nicosammito avatar Feb 13 '24 14:02 nicosammito

https://github.com/adobe/react-spectrum/issues/2506 is related

LFDanLu avatar Mar 06 '24 23:03 LFDanLu

Please consider prioritizing this issue.

TKDev7 avatar May 08 '24 10:05 TKDev7