react-spectrum
react-spectrum copied to clipboard
react-transition-group: pass nodeRef so findDOMNode isn't used
https://github.com/adobe/react-spectrum/pull/1108/ is failing due to Adobe CLA, opening a new PR to fix that @mischnic : Part of #779
There are more problems with strict mode (which is why I didn't enable strict mode in tests or Storybook yet), this is just fixing the react-transition-group and findDOMNode problem.
โ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
๐ Test Instructions:
๐งข Your Project:
I think this isn't needed anymore?
I don't remember most of the context at this point, but do we not want to upgrade react-transition-group? Still, happy to close, we can open an issue to do the upgrade at another point
Hey, what's preventing us from getting this merged ? This is a blocker for us currently, it is still an issue :(
Related: https://github.com/adobe/react-spectrum/pull/3291
Handled in https://github.com/adobe/react-spectrum/pull/3865