react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

react-transition-group: pass nodeRef so findDOMNode isn't used

Open snowystinger opened this issue 5 years ago โ€ข 8 comments

https://github.com/adobe/react-spectrum/pull/1108/ is failing due to Adobe CLA, opening a new PR to fix that @mischnic : Part of #779

There are more problems with strict mode (which is why I didn't enable strict mode in tests or Storybook yet), this is just fixing the react-transition-group and findDOMNode problem.

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger avatar Nov 06 '20 22:11 snowystinger

Build successful! ๐ŸŽ‰

adobe-bot avatar Nov 06 '20 23:11 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Nov 06 '20 23:11 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Nov 17 '20 23:11 adobe-bot

Build successful! ๐ŸŽ‰

adobe-bot avatar Dec 23 '20 20:12 adobe-bot

I think this isn't needed anymore?

devongovett avatar Jun 20 '22 16:06 devongovett

I don't remember most of the context at this point, but do we not want to upgrade react-transition-group? Still, happy to close, we can open an issue to do the upgrade at another point

snowystinger avatar Jun 22 '22 15:06 snowystinger

Hey, what's preventing us from getting this merged ? This is a blocker for us currently, it is still an issue :(

alkanna avatar Jul 24 '22 16:07 alkanna

Related: https://github.com/adobe/react-spectrum/pull/3291

dannify avatar Jul 25 '22 15:07 dannify

Handled in https://github.com/adobe/react-spectrum/pull/3865

LFDanLu avatar Jan 13 '23 17:01 LFDanLu