helix-website icon indicating copy to clipboard operation
helix-website copied to clipboard

feat: no reload

Open kptdobe opened this issue 1 year ago • 4 comments

Why reloading the full page while a simple redraw should do the job and avoid the flicker.

Redrawing might require to fetch a different set of data if the view, startDate or endDate is changed. I noticed also that when there are a lot of data to fetch (like 1GB when loading adobe.com week view), the UI might feel unresponsive. I have added a loading spinner and disabled all facets.

https://no-reload--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=www.adobe.com

kptdobe avatar Sep 25 '24 12:09 kptdobe

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

  • [ ] Re-run PSI checks
  • [ ] Re-sync branch
Commits

aem-code-sync[bot] avatar Sep 25 '24 12:09 aem-code-sync[bot]

@kptdobe the code doesn't fetch the data when you increase the range (week to month or month to year).

https://github.com/user-attachments/assets/3e99554d-c134-41a2-a34e-f1e81cdae2d0

vdua avatar Sep 25 '24 14:09 vdua

Not merging for now as this is not crucial. But I am looking at selection gesture on the chart to "drill down" in the period, having a client side refresh will make the experience much better.

kptdobe avatar Oct 14 '24 14:10 kptdobe