enable "cloud" profile for all CI builds and release

[kwin]

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] I have signed the Adobe Open Source CLA.
• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[codecov[bot]]

Codecov Report

Merging #775 (93db0ce) into develop (0139727) will decrease coverage by 1.25%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #775      +/-   ##
=============================================
- Coverage      29.46%   28.20%   -1.26%     
- Complexity       447      459      +12     
=============================================
  Files            146      155       +9     
  Lines           3716     3974     +258     
  Branches         515      545      +30     
=============================================
+ Hits            1095     1121      +26     
- Misses          2477     2704     +227     
- Partials         144      149       +5     

Flag	Coverage Δ
unittests	28.20% <ø> (-1.26%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tions/downloads/impl/PlaceholderDownloadEntry.java	0.00% <0.00%> (ø)
...mponents/actions/downloads/impl/DownloadsImpl.java	2.77% <0.00%> (ø)
...tions/download/async/DownloadTargetParameters.java	100.00% <0.00%> (ø)
...oad/async/impl/ExpressionDownloadArchiveNamer.java	66.66% <0.00%> (ø)
...ditions/download/async/impl/DownloadEntryImpl.java	0.00% <0.00%> (ø)
...nc/impl/NamedRenditionDownloadTargetProcessor.java	0.00% <0.00%> (ø)
...ons/assetshare/util/impl/RequireAemCanaryImpl.java	0.00% <0.00%> (ø)
...sync/impl/AsyncAssetRenditionsDownloadServlet.java	4.22% <0.00%> (ø)
...ntent/renditions/download/async/DownloadEntry.java	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0139727...93db0ce. Read the comment docs.

[bstopp]

If there is a cloud profile, is there also a non-cloud profile? Each profile needs its own build command in the workflows to ensure the artifacts are created and published.

E.g. if you need to run -Pcloud to build for AEMaaCS; i assume leaving this off will build unique artifacts for AEM 6.x;

Each workflow should have a new step to add -Pcloud build option, while leaving the existing intact.

[kwin]

There is only cloud, the classic artifacts are always built (because the cloud module relies on them)

[bstopp]

This should have been "If you need the default for the Cloud, but you will always build the cloud profile; why have a separate profile?"

[kwin]

The build is faster without profile cloud as then you only build the classic artifacts. However the profile „cloud“ is already merged to develop. For now we should make sure that CI covers it. If you have a different proposal how to build for cloud please raise it separately.

[davidjgonzalez]

@kwin IIUC you introduced the cloud profile, mainly for local development? (vs. just always building everything) to make that build/cycle faster for 6.5.x developers?

[kwin]

@davidjgonzalez Yes, the separation in a dedicated profile is exactly for that use case.

[kwin]

@davidjgonzalez Either this PR should be merged or the profile cloud should be removed. Currently the CI is just incomplete!