asset-share-commons icon indicating copy to clipboard operation
asset-share-commons copied to clipboard

Asset Share Commons Share And Download buttons not functioning

Open Shubhankar-Kumar-1 opened this issue 3 years ago • 7 comments

We are using Asset share commons 2.1.12 version.....we were using the share and download modals that are present but we are not able to make them work.

We believe it to be an error in the UrlImpl.java file present at the location "asset-share-commons-asset-share-commons-2.1.12\asset-share-commons-asset-share-commons-2.1.12\core\src\main\java\com\adobe\aem\commons\assetshare\content\properties\impl" as this the error that is getting thrown when we use the button.

MicrosoftTeams-image (8)

Can you please help us with this issue?

Shubhankar-Kumar-1 avatar Apr 28 '22 14:04 Shubhankar-Kumar-1

Is this happening for every asset? If only certain ones, can you provide the path (or even better a package of an asset that doesn't work)?

Thanks!

davidjgonzalez avatar Apr 28 '22 23:04 davidjgonzalez

This is happening for every asset from what we can see....

Shubhankar-Kumar-1 avatar Apr 29 '22 00:04 Shubhankar-Kumar-1

path from where we try to download: "/content/dcx-mediaplace/asc/en/home/category-page/subcategoryList/subcategoryResult.html".

Asset path example: "/content/dam/multisite/multi-brand/parts/na/multi-country/images/complementary/online-complementary/12499/1234-PIC31.jpg".

Shubhankar-Kumar-1 avatar Apr 29 '22 01:04 Shubhankar-Kumar-1

@Shubhankar-Kumar-1 -

What version of AEM are you one?

So it looks like the problem is the Path computed property is not active, thus not injected, thus null.

https://github.com/adobe/asset-share-commons/blob/develop/core/src/main/java/com/adobe/aem/commons/assetshare/content/properties/impl/UrlImpl.java#L74

Can you check in /system/console/components what the OSGI component registration for PathImpl looks like?

com.adobe.aem.commons.assetshare.content.properties.impl.PathImpl

2022-04-29 at 12 26 PM

FWIW i cannot reproduce this.

davidjgonzalez avatar Apr 29 '22 16:04 davidjgonzalez

image

this is the component status in our AEM and our AEM version is 6.5.11.

SO what is happening is that, when we select the assets and click on the download button we get an server error(500).... saying that POST request failed....in the backend logs we are getting the error message as shown in the first photo.

Shubhankar-Kumar-1 avatar Apr 29 '22 16:04 Shubhankar-Kumar-1

I would kindly request you to help us on this matter as we are not able to fix this issue and the code is already in production...this will get escalated on our side if we don't fix this soon. We can also connect if required for this matter.

Shubhankar-Kumar-1 avatar May 02 '22 10:05 Shubhankar-Kumar-1

Hi @Shubhankar-Kumar-1 - sorry, I cannot reproduce this w/ 2.1.12 on 6.5.11 -- this all works fine for me. So I don't know how to help you. I suggest you try reproducing this on a vanilla AEM 6.5 SP11 with vanilla ASC 2.1.12 (or even better, you should be using 2.2.0)

The exception you provided doesn't make sense since from what i can tell the only thing i can see on that line that would cause a NPE is if the PathImpl OSGi component is not active, which you show as active in the previous screenshot.

Maybe you can download ASC source code (using git tag for 2.1.12) and hook up a remote debugger to your local that is exhibiting this to understand whats going on in your AEM better.

davidjgonzalez avatar May 02 '22 16:05 davidjgonzalez

Closing. Please re-open of you need more help.

davidjgonzalez avatar Sep 14 '22 01:09 davidjgonzalez