asset-share-commons icon indicating copy to clipboard operation
asset-share-commons copied to clipboard

Ability to undo-filter using property filters

Open oscar-cami opened this issue 6 years ago • 8 comments

Scenario and Problem Description For our business we have added a number of properties that are selected in ways of drop-down menus within the metadata of the asset. These properties are used for other teams to search for assets within the Asset Share Commons Page.

The problem we have is that you use the filter choosing one property and it works fine however, the only way to undo-filter is to click on the Reset button which removes ALL filters applied.

Describe the solution you'd like We would like to have the ability to undo individual property filters. That will allow the users to go back to the previous situation in case they applied several filters in cascade. Otherwise the only way they have is to reset and start over again.

Describe alternatives you've considered We have only a workaround which is to Reset ALL filters and start again with the search. This is not the most optimum way of searching... undo-filter

oscar-cami avatar Jun 25 '19 07:06 oscar-cami

Can you make a blank drop down option value (Label value doesn’t matter) the user can select?

davidjgonzalez avatar Jun 25 '19 11:06 davidjgonzalez

Hi David,

I have tried but the new blank choice within the drop-down but this option is not accessible. It seems it does not exist the blank option.

Can you please provide more details how I can add such option?

Thanks, Oscar

oscar-cami avatar Jun 25 '19 12:06 oscar-cami

image

image

oscar-cami avatar Jun 25 '19 13:06 oscar-cami

@oscar-cami shoot - it looks like Core Components OptionsImpl [1] (which we use) filters blank values out :(

Not sure what the best way to fix this is ... 🤔 Ideally this would be changed centrally, rather than having extra code for every component that should handle this case (since we use Options in several places)....

https://github.com/adobe/aem-core-wcm-components/blob/master/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/form/OptionsImpl.java#L180

davidjgonzalez avatar Jun 25 '19 14:06 davidjgonzalez

Hi David,

Thanks for your answer and marking this as a bug. Can we predict an estimate time to deliver for a fix?

Thanks a lot in advance, Oscar

oscar-cami avatar Jun 26 '19 07:06 oscar-cami

Hi David,

Do you have any updates for me in regards to this bug?

Thanks, Oscar

oscar-cami avatar Jul 29 '19 09:07 oscar-cami

@oscar-cami hi - no ETA. Can you suggest a solution and provide a fix (assuming the proposed solution makes sense in the context of ASC)? Thanks

davidjgonzalez avatar Jul 29 '19 16:07 davidjgonzalez

Hi David, my consultant from Adobe will look into this and let me know which is the best solution to allow "Undo Filter" individually.

Please keep this bug in the roadmap to release the fix on 1.8.2 always better later than never :)

Thanks, Oscar

oscar-cami avatar Jul 30 '19 06:07 oscar-cami