asset-share-commons icon indicating copy to clipboard operation
asset-share-commons copied to clipboard

Provide Loading Mask for loadMore event

Open kaushalmall opened this issue 7 years ago • 10 comments

Is your feature request related to a problem? Please describe. For Asset Share when a lot of assets are being loaded and it takes a while to load, there is no visual indication to the users that work is being done.

Describe the solution you'd like A loading mask when the loadMore event is fired would provide the visual aid to end users.

Describe alternatives you've considered N/A

Additional context For example, in the screenshot below, the request took 94848 ms

image

kaushalmall avatar Sep 04 '18 19:09 kaushalmall

@kaushalmall I think a 1.5min+ query is the real issue?

davidjgonzalez avatar Sep 04 '18 20:09 davidjgonzalez

Absolutely. IMO, a loading mask is a good addition irrespective of the issue we are seeing at the customer. Looking to fix that independent of the loading mask enhancement request here.

kaushalmall avatar Sep 04 '18 20:09 kaushalmall

The issue w/ load masking is when the load is fast, it can cause flickering.. thoughts on how this would look/work?

davidjgonzalez avatar Sep 04 '18 20:09 davidjgonzalez

can we make it a config? Show/Don't show loading mask on the search results component. Not sure if that's possible.

kaushalmall avatar Sep 04 '18 20:09 kaushalmall

sure - it can be a config. The hesitation you're sensing is it doesn't seem generally useful, and has a decent chance of UX oddities (since not all requests are slow, even when some may take 90s).

If you can come up w some system that is good for fast and slow requests, i don't have any issues.

davidjgonzalez avatar Sep 04 '18 20:09 davidjgonzalez

for sure. I'll play around with it.

kaushalmall avatar Sep 04 '18 20:09 kaushalmall

I'm working on a project where we could benefit from this as well.

prestoncrawford avatar Jan 16 '19 23:01 prestoncrawford

@prestoncrawford curious - is this to combat slow query times? If so, any idea what’s causing the slow queries? and how slow is slow?

davidjgonzalez avatar Jan 17 '19 03:01 davidjgonzalez

@davidjgonzalez - Yes, this is a slow query. Worse than the OP, 2.8s. We're working on identifying what's causing the slow query. We're not sure yet.

prestoncrawford avatar Jan 17 '19 23:01 prestoncrawford

Fwiw OP was 94 seconds :) so atleast you’re not that slow! Though 3s is still way to slow ... in the meantime of this feature, trying using: https://chrome.google.com/webstore/detail/aem-chrome-plug-in/ejdcnikffjleeffpigekhccpepplaode

To inspect the slow query, and if you can post the query and query plan to this issue.

davidjgonzalez avatar Jan 18 '19 01:01 davidjgonzalez