aem-core-forms-components icon indicating copy to clipboard operation
aem-core-forms-components copied to clipboard

Testing parallelisation and test splitting in circleci

Open ravise5 opened this issue 3 years ago • 4 comments

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes and the overall coverage did not decrease.
  • [ ] All unit tests pass on CircleCi.
  • [ ] I ran all tests locally and they pass.

ravise5 avatar Nov 30 '22 18:11 ravise5

This is a POC One concern is we are passing the glob of test files to the it-test.js script inside which we are using a shell script for starting the mvn command. So I'm not sure if parallelisation will occur. So for time being I've limited the number of executors to be spun up to only 4.

ravise5 avatar Nov 30 '22 19:11 ravise5

I've solved the problem of all tests getting executed on every newly spun up executor by passing the split test info as command line arguments to the script it-test.js and then modifying the pom.xml of ui.tests to accept these as an arguments which can be then passed to the cypress run --spec="" command. But for some reason this command is erroring out inside the ci but working fine locally. Currently debugging this part.

ravise5 avatar Dec 02 '22 09:12 ravise5

Things remaining to fix.

  1. The glob of test files need to be tweaked to exclude circle ci directory files.
  2. Cypress run --spec command defined in pom erroring out.

ravise5 avatar Dec 04 '22 16:12 ravise5

Codecov Report

Merging #357 (d83581b) into dev (6dbcdee) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d83581b differs from pull request most recent head 40d8433. Consider uploading reports for the commit 40d8433 to get more accurate results

@@            Coverage Diff            @@
##                dev     #357   +/-   ##
=========================================
  Coverage     80.46%   80.46%           
  Complexity      579      579           
=========================================
  Files            80       80           
  Lines          1694     1694           
  Branches        206      206           
=========================================
  Hits           1363     1363           
  Misses          215      215           
  Partials        116      116           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jan 19 '23 12:01 codecov[bot]