aem-core-forms-components
aem-core-forms-components copied to clipboard
adobe
UE: Supporting a new CRX property for multi select dropdown's default values
Description
https://jira.corp.adobe.com/browse/FORMS-16246
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 95 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.50%. Comparing base (
a59c898) to head (21df15f). Report is 1 commits behind head on dev.
Additional details and impacted files
@@ Coverage Diff @@
## dev #1454 +/- ##
============================================
+ Coverage 82.34% 82.50% +0.15%
- Complexity 1003 1010 +7
============================================
Files 108 108
Lines 2611 2623 +12
Branches 373 378 +5
============================================
+ Hits 2150 2164 +14
+ Misses 272 270 -2
Partials 189 189
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please add test cases. Shouldn't the new property be prefixed with fd: ?
@rismehta I don't think so, since we do not have special logic for its handling, It acts like a new OOTB property that is a part of the reserved properties list.
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 93 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 92 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 93 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |