aem-core-forms-components
aem-core-forms-components copied to clipboard
adobe
Add Show Popup property under custom property
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] I have signed the Adobe Open Source CLA.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.39%. Comparing base (
75e25e7) to head (176d8bd).
Additional details and impacted files
@@ Coverage Diff @@
## dev #1437 +/- ##
=========================================
Coverage 82.38% 82.39%
Complexity 946 946
=========================================
Files 105 105
Lines 2430 2431 +1
Branches 332 332
=========================================
+ Hits 2002 2003 +1
Misses 260 260
Partials 168 168
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 95 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 94 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 91 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| focus-order-semantics | minor |
| label-title-only | serious |
| landmark-one-main | moderate |
| region | moderate |
| target-size | serious |
Lighthouse scores (mobile)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 92 | 96 | 96 | 75 |
Lighthouse scores (desktop)
| Performance | Accessibility | Best-Practices | SEO | |
|---|---|---|---|---|
| Scores | 100 | 96 | 96 | 75 |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |
Accessibility Violations Found
| Id | Impact |
|---|---|
| label-title-only | serious |
| target-size | serious |