aem-core-forms-components icon indicating copy to clipboard operation
aem-core-forms-components copied to clipboard

FORMS-15150 Runtime client libraries are loaded in authoring for tabs…

Open dmaurya929 opened this issue 1 year ago • 8 comments

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes and the overall coverage did not decrease.
  • [ ] All unit tests pass on CircleCi.
  • [ ] I ran all tests locally and they pass.

dmaurya929 avatar Aug 13 '24 18:08 dmaurya929

This is new PR of https://github.com/adobe/aem-core-forms-components/pull/1293 All review comments are incorporated !!

dmaurya929 avatar Aug 13 '24 18:08 dmaurya929

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar Aug 13 '24 19:08 adobe-bot

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 87 96 96 75

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 14 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 96 96 75

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 20 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar Aug 23 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 23 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 89 96 96 75

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Aug 26 '24 06:08 adobe-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.94%. Comparing base (30da958) to head (87846b5). Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1355   +/-   ##
=========================================
  Coverage     81.94%   81.94%           
  Complexity      899      899           
=========================================
  Files           103      103           
  Lines          2337     2337           
  Branches        317      317           
=========================================
  Hits           1915     1915           
  Misses          259      259           
  Partials        163      163           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '24 06:08 codecov[bot]